Fix os.host for Cosmopolitan build
#2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
force-pushed
the
fix-os-host-cosmo
branch
from
5046a12
to
e0f3c76
Compare
samsinsane
requested changes
Oct 4, 2024
tritao
force-pushed
the
fix-os-host-cosmo
branch
from
e0f3c76
to
db2a832
Compare
Jarod42
approved these changes
Oct 4, 2024
samsinsane
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
os.hostfor Cosmopolitan buildAnything else we should know?
Also a minor cleanup where
_TARGET_OSis moved to Lua which would have prevented this bug in the first place.Should we still leave an assignement to
_TARGET_ARCH = niljust for documentation sake that it exists?